Source/web/WebInputEventConversion.cpp - Issue 759073002: Add canScroll bit to WebMouseWheelEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebInputEventConversion.cpp

Issue 759073002: Add canScroll bit to WebMouseWheelEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Made changes based on comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebInputEventConversion.cpp

diff --git a/Source/web/WebInputEventConversion.cpp b/Source/web/WebInputEventConversion.cpp

index 1fa3ef12377eccd97dc053e31dd96266d4320402..ea52bbc284739b43866c718bb079dee1512ae05e 100644

--- a/Source/web/WebInputEventConversion.cpp

+++ b/Source/web/WebInputEventConversion.cpp

@@ -154,6 +154,7 @@ PlatformWheelEventBuilder::PlatformWheelEventBuilder(Widget* widget, const WebMo

m_modifiers |= PlatformEvent::MetaKey;

m_hasPreciseScrollingDeltas = e.hasPreciseScrollingDeltas;

+ m_canScroll = e.canScroll;

#if OS(MACOSX)

m_phase = static_cast<PlatformWheelEventPhase>(e.phase);

m_momentumPhase = static_cast<PlatformWheelEventPhase>(e.momentumPhase);

@@ -641,6 +642,7 @@ WebMouseWheelEventBuilder::WebMouseWheelEventBuilder(const Widget* widget, const

wheelTicksX = event.ticksX();

wheelTicksY = event.ticksY();

scrollByPage = event.deltaMode() == WheelEvent::DOM_DELTA_PAGE;

+ canScroll = event.canScroll();

}

WebKeyboardEventBuilder::WebKeyboardEventBuilder(const KeyboardEvent& event)