Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: net/spdy/hpack_huffman_table.h

Issue 759063003: Fix "value possibly truncated" warnings on MSVC, net/spdy/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comment Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/fuzzing/hpack_fuzz_util.cc ('k') | net/spdy/hpack_huffman_table.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/hpack_huffman_table.h
diff --git a/net/spdy/hpack_huffman_table.h b/net/spdy/hpack_huffman_table.h
index f776ddd2887e63dccabd9e026a5f54b36cbc5a53..55352d4e639c14b8d7054c3603a3c5ddaf987c15 100644
--- a/net/spdy/hpack_huffman_table.h
+++ b/net/spdy/hpack_huffman_table.h
@@ -67,7 +67,8 @@ class NET_EXPORT_PRIVATE HpackHuffmanTable {
// Prepares HpackHuffmanTable to encode & decode the canonical Huffman
// code as determined by the given symbols. Must be called exactly once.
// Returns false if the input symbols define an invalid coding, and true
- // otherwise. Symbols must be presented in ascending ID order with no gaps.
+ // otherwise. Symbols must be presented in ascending ID order with no gaps,
+ // and |symbol_count| must fit in a uint16.
bool Initialize(const Symbol* input_symbols, size_t symbol_count);
// Returns whether Initialize() has been successfully called.
« no previous file with comments | « net/spdy/fuzzing/hpack_fuzz_util.cc ('k') | net/spdy/hpack_huffman_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698