Fix "value possibly truncated" warnings on MSVC, net/spdy/ edition.

net/spdy/hpack_huffman_table.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/hpack_huffman_table.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/logging.h"
@@ skipping 38 matching lines @@
   return size_t(1) << indexed_length;
 }
 
 HpackHuffmanTable::HpackHuffmanTable() {}
 
 HpackHuffmanTable::~HpackHuffmanTable() {}
 
 bool HpackHuffmanTable::Initialize(const HpackHuffmanSymbol* input_symbols,
                                    size_t symbol_count) {
   CHECK(!IsInitialized());
+  if (symbol_count > std::numeric_limits<uint16>::max())
+    return false;

[Bence, 2014/12/01 18:18:38]

Could this be a DCHECK to document requirements?  We are not expecting the
caller do to error handling anyway.

[Peter Kasting, 2014/12/02 02:13:55]

Changed to a DCHECK and added a note to the declaration comment.

 
   std::vector<Symbol> symbols(symbol_count);
   // Validate symbol id sequence, and copy into |symbols|.
-  for (size_t i = 0; i != symbol_count; i++) {
+  for (uint16 i = 0; i != symbol_count; i++) {
     if (i != input_symbols[i].id) {
       failed_symbol_id_ = i;
       return false;
     }
     symbols[i] = input_symbols[i];
   }
   // Order on length and ID ascending, to verify symbol codes are canonical.
   std::sort(symbols.begin(), symbols.end(), SymbolLengthAndIdCompare);
   if (symbols[0].code != 0) {
     failed_symbol_id_ = 0;
@@ skipping 241 matching lines @@
       bits = bits << entry.length;
       bits_available -= entry.length;
     }
     peeked_success = in->PeekBits(&bits_available, &bits);
   }
   NOTREACHED();
   return false;
 }
 
 }  // namespace net