ash/shell.cc - Issue 759063002: Move Screen Rotation from MaximizeModeController to ScreenOrientationController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell.cc

Issue 759063002: Move Screen Rotation from MaximizeModeController to ScreenOrientationController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/content/display/screen_orientation_delegate_chromeos_unittest.cc ('K') | « ash/content/display/screen_orientation_delegate_chromeos_unittest.cc ('k') | ash/system/chromeos/rotation/tray_rotation_lock.h » ('j') | ash/wm/maximize_mode/maximize_mode_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/shell.cc

diff --git a/ash/shell.cc b/ash/shell.cc

index f8e6aab42c74b8832e0de6d10f008c2a2dc29d96..f42790d200dfce18c688d385f81c853aee07f022 100644

--- a/ash/shell.cc

+++ b/ash/shell.cc

@@ -486,8 +486,8 @@ void Shell::RemoveShellObserver(ShellObserver* observer) {

#if defined(OS_CHROMEOS)

bool Shell::ShouldSaveDisplaySettings() {

return !((maximize_mode_controller_->IsMaximizeModeWindowManagerEnabled() &&

flackr 2014/11/27 15:39:15 Do we need to check if maximize mode window manage

jonross 2014/12/10 17:57:30 Yeah the maximize mode check is no longer needed

- maximize_mode_controller_->

- ignore_display_configuration_updates()) ||

+ screen_orientation_delegate_

+ ->ignore_display_configuration_updates()) ||

resolution_notification_controller_->DoesNotificationTimeout());

}

#endif