Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1901)

Unified Diff: ash/shell.cc

Issue 759063002: Move Screen Rotation from MaximizeModeController to ScreenOrientationController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change similarity to account for moved files Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shell.cc
diff --git a/ash/shell.cc b/ash/shell.cc
index 5d097b6f3a834499f1cbffe3f7e0a16161bb6855..cbea4910b0e4410501e70339fc65eb275c2c3847 100644
--- a/ash/shell.cc
+++ b/ash/shell.cc
@@ -121,7 +121,7 @@
#include "ui/gfx/x/x11_types.h"
#endif // defined(USE_X11)
#include "ash/ash_constants.h"
-#include "ash/content/display/screen_orientation_delegate_chromeos.h"
+#include "ash/content/display/screen_orientation_controller_chromeos.h"
#include "ash/display/display_change_observer_chromeos.h"
#include "ash/display/display_configurator_animation.h"
#include "ash/display/display_error_observer_chromeos.h"
@@ -485,9 +485,8 @@ void Shell::RemoveShellObserver(ShellObserver* observer) {
#if defined(OS_CHROMEOS)
bool Shell::ShouldSaveDisplaySettings() {
- return !((maximize_mode_controller_->IsMaximizeModeWindowManagerEnabled() &&
- maximize_mode_controller_->
- ignore_display_configuration_updates()) ||
+ return !(screen_orientation_controller_
+ ->ignore_display_configuration_updates() ||
resolution_notification_controller_->DoesNotificationTimeout());
}
#endif
@@ -696,9 +695,12 @@ Shell::~Shell() {
// TooltipController is deleted with the Shell so removing its references.
RemovePreTargetHandler(tooltip_controller_.get());
+#if defined(OS_CHROMEOS)
+ screen_orientation_controller_.reset();
+#endif
+
// Destroy maximize mode controller early on since it has some observers which
// need to be removed.
- maximize_mode_controller_->Shutdown();
maximize_mode_controller_.reset();
// AppList needs to be released before shelf layout manager, which is
@@ -1062,7 +1064,7 @@ void Shell::Init(const ShellInitParams& init_params) {
new VideoActivityNotifier(video_detector_.get()));
bluetooth_notification_controller_.reset(new BluetoothNotificationController);
last_window_closed_logout_reminder_.reset(new LastWindowClosedLogoutReminder);
- screen_orientation_delegate_.reset(new ScreenOrientationDelegate());
+ screen_orientation_controller_.reset(new ScreenOrientationController());
#endif
// The compositor thread and main message loop have to be running in
// order to create mirror window. Run it after the main message loop

Powered by Google App Engine
This is Rietveld 408576698