Move Screen Rotation from MaximizeModeController to ScreenOrientationController

ash/ash.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
     'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/chrome',
     # These files lists are shared with the GN build.
     'ash_sources': [
@@ skipping 29 matching lines @@
       'autoclick/autoclick_controller.h',
       'ash_constants.cc',
       'ash_constants.h',
       'ash_export.h',
       'ash_switches.cc',
       'ash_switches.h',
       'ash_touch_exploration_manager_chromeos.cc',
       'ash_touch_exploration_manager_chromeos.h',
       'cancel_mode.cc',
       'cancel_mode.h',
-      'content/display/screen_orientation_delegate_chromeos.cc',
-      'content/display/screen_orientation_delegate_chromeos.h',
+      'content/display/screen_orientation_controller_chromeos.cc',
+      'content/display/screen_orientation_controller_chromeos.h',
       'debug.cc',
       'debug.h',
       'default_accessibility_delegate.cc',
       'default_accessibility_delegate.h',
       'default_user_wallpaper_delegate.cc',
       'default_user_wallpaper_delegate.h',
       'desktop_background/desktop_background_controller.cc',
       'desktop_background/desktop_background_controller.h',
       'desktop_background/desktop_background_controller_observer.h',
       'desktop_background/desktop_background_view.cc',
@@ skipping 696 matching lines @@
     ],
     'ash_unittests_sources': [
       'accelerators/accelerator_commands_unittest.cc',
       'accelerators/accelerator_controller_unittest.cc',
       'accelerators/accelerator_filter_unittest.cc',
       'accelerators/accelerator_table_unittest.cc',
       'accelerators/magnifier_key_scroller_unittest.cc',
       'accelerators/spoken_feedback_toggler_unittest.cc',
       'ash_touch_exploration_manager_chromeos_unittest.cc',
       'autoclick/autoclick_unittest.cc',
-      'content/display/screen_orientation_delegate_chromeos_unittest.cc',
+      'content/display/screen_orientation_controller_chromeos_unittest.cc',
       'desktop_background/desktop_background_controller_unittest.cc',
       'desktop_background/wallpaper_resizer_unittest.cc',
       'dip_unittest.cc',
       'display/display_change_observer_chromeos_unittest.cc',
       'display/display_controller_unittest.cc',
       'display/display_error_observer_chromeos_unittest.cc',
       'display/display_info_unittest.cc',
       'display/display_manager_unittest.cc',
       'display/mirror_window_controller_unittest.cc',
       'display/mouse_cursor_event_filter_unittest.cc',
@@ skipping 179 matching lines @@
             '../chromeos/chromeos.gyp:power_manager_proto',
             '../device/bluetooth/bluetooth.gyp:device_bluetooth',
             '../ui/chromeos/ui_chromeos.gyp:ui_chromeos_resources',
             '../ui/chromeos/ui_chromeos.gyp:ui_chromeos_strings',
             '../ui/chromeos/ui_chromeos.gyp:ui_chromeos',
             '../ui/display/display.gyp:display',
             '../ui/display/display.gyp:display_util',
           ],
         }, { # else: chromeos!=1
           'sources!': [
+            'content/display/screen_orientation_controller_chromeos.cc',
+            'content/display/screen_orientation_controller_chromeos.h',

[flackr, 2014/12/12 20:46:06]

We have to explicitly exclude these files? Shouldn't the filename_rules take
care of this?
https://code.google.com/p/chromium/codesearch#chromium/src/build/filename_rul...

[jonross, 2015/01/06 19:56:10]

Did not know of those. Removed

             'display/display_configurator_animation.cc',
             'display/display_configurator_animation.h',
             'display/resolution_notification_controller.cc',
             'display/resolution_notification_controller.h',
             'system/tray/media_security/media_capture_observer.h',
             'system/tray/media_security/multi_profile_media_tray_item.cc',
             'system/tray/media_security/multi_profile_media_tray_item.h',
             'touch/touch_transformer_controller.cc',
             'touch/touch_transformer_controller.h',
             'touch/touchscreen_util.cc',
@@ skipping 125 matching lines @@
         'ash_strings.gyp:ash_strings',
         'ash_test_support',
         'ash_with_content',
       ],
       'sources': [
         '<@(ash_unittests_sources)',
       ],
       'conditions': [
         ['chromeos==0', {
           'sources!': [
-            'content/display/screen_orientation_delegate_chromeos_unittest.cc',
+            'content/display/screen_orientation_controller_chromeos_unittest.cc',
             # TODO(zork): fix this test to build on Windows. See: crosbug.com/26906
             'focus_cycler_unittest.cc',
             # All tests for multiple displays: not supported on Windows Ash.
             'wm/drag_window_resizer_unittest.cc',
             # Can't resize on Windows Ash. http://crbug.com/165962
             'magnifier/magnification_controller_unittest.cc',
             'wm/workspace/workspace_window_resizer_unittest.cc',
             'sticky_keys/sticky_keys_overlay_unittest.cc',
             'sticky_keys/sticky_keys_unittest.cc',
+            'system/chromeos/rotation/tray_rotation_lock_unittest.cc',
             'system/tray/media_security/multi_profile_media_tray_item_unittest.cc',
             'autoclick/autoclick_unittest.cc',
             "virtual_keyboard_controller_unittest.cc"
           ],
           'sources': [
             '<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_unscaled_resources.rc',
           ],
           # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
           'msvs_disabled_warnings': [ 4267, ],
         }],
@@ skipping 166 matching lines @@
             '../build/isolate.gypi',
           ],
           'sources': [
             'ash_unittests.isolate',
           ],
         },
       ],
     }],
   ],
 }