Issue 759013003: Avoid number range holes in bitset types.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -140 lines)			Patch
M	src/compiler/typer.cc	View	1 2 3	3 chunks	+4 lines, -8 lines	0 comments	Download
M	src/types.h	View	1 2 3 4	4 chunks	+71 lines, -50 lines	0 comments	Download
M	src/types.cc	View		3 chunks	+22 lines, -18 lines	0 comments	Download
M	test/cctest/compiler/test-js-typed-lowering.cc	View	1 2 3	3 chunks	+22 lines, -18 lines	0 comments	Download
M	test/cctest/test-types.cc	View		2 chunks	+43 lines, -27 lines	0 comments	Download
M	test/cctest/types-fuzz.h	View	1 2 3	3 chunks	+3 lines, -14 lines	0 comments	Download
M	test/unittests/compiler/js-builtin-reducer-unittest.cc	View	1 2	1 chunk	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jarin

Could you take a look, please? https://codereview.chromium.org/759013003/diff/20001/src/compiler/typer.cc File src/compiler/typer.cc (right): https://codereview.chromium.org/759013003/diff/20001/src/compiler/typer.cc#newcode189 src/compiler/typer.cc:189: random_fun_ = Type::Function(Type::OrderedNumber(), ...

6 years ago (2014-12-02 20:46:20 UTC) #2

rossberg

lgtm https://codereview.chromium.org/759013003/diff/40001/src/types.h File src/types.h (right): https://codereview.chromium.org/759013003/diff/40001/src/types.h#newcode182 src/types.h:182: #define INTERNAL_BITSET_TYPE_LIST(V) \ How about moving OtherString and ...

6 years ago (2014-12-03 14:07:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/759013003/80001

6 years ago (2014-12-10 16:11:36 UTC) #5

Jarin

6 years ago (2014-12-10 18:24:15 UTC) #7

Message was sent while issue was closed.

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/794663002/ by jarin@chromium.org.

The reason for reverting is: For breaking the waterfall (run-json-stringify
test)..

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 759013003: Avoid number range holes in bitset types. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Tweak #

Patch Set 3 : Add PlainNumber type to bunch of tests. #

Patch Set 4 : Rebase & indent fix #

Patch Set 5 : Another rebase #

Messages