Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 7590014: Merge 92002 - Scroll animation refinements. (Closed)

Created:
7 years, 10 months ago by Vangelis Kokkevis
Modified:
7 years, 10 months ago
Reviewers:
Vangelis Kokkevis
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/835/
Visibility:
Public.

Description

Merge 92002 - Scroll animation refinements. https://bugs.webkit.org/show_bug.cgi?id=65154 Patch by Scott Byer <scottbyer@chromium.org>; on 2011-07-29 Reviewed by Adam Barth. Fix scroll animation bugs when scrolling to the ends of a document. Smooth over slow event repeat rates better. Fix tests to allow for unit testing of scrolling up and not just down. Source/WebCore: Additional unit tests added to ScrollAnimatorNoneTest: ScrollQuadraticSmoothed, ScrollLotsQuadraticSmoothed, ScrollDownToBumper, ScrollUpToBumper * platform/ScrollAnimatorNone.cpp: (WebCore::ScrollAnimatorNone::Parameters::Parameters): (WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters): (WebCore::ScrollAnimatorNone::scroll): * platform/ScrollAnimatorNone.h: Source/WebKit/chromium: Additional unit tests added to ScrollAnimatorNoneTest: ScrollQuadraticSmoothed, ScrollLotsQuadraticSmoothed, ScrollDownToBumper, ScrollUpToBumper * tests/ScrollAnimatorNoneTest.cpp: (ScrollAnimatorNoneTest::reset): (ScrollAnimatorNoneTest::updateDataFromParameters): (ScrollAnimatorNoneTest::animateScroll): (ScrollAnimatorNoneTest::checkDesiredPosition): (ScrollAnimatorNoneTest::checkSoftLanding): TBR=commit-queue@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92726

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -32 lines) Patch
M Source/WebCore/platform/ScrollAnimatorNone.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/WebCore/platform/ScrollAnimatorNone.cpp View 6 chunks +19 lines, -13 lines 0 comments Download
M Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp View 16 chunks +177 lines, -18 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Vangelis Kokkevis
7 years, 10 months ago (2011-08-09 23:38:07 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698