Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 758973002: Remove unnessary check to skip drawing. (Closed)

Created:
6 years ago by egdaniel
Modified:
6 years ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove unnessary check to skip drawing. This is now checked during the OptDrawStates creation and thus is no longer needed here. I have varified that this code path is never hit. BUG=skia: Committed: https://skia.googlesource.com/skia/+/74d80eba370557c22cebef6c3be0875c32e1b17b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/gpu/gl/GrGpuGL_program.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
egdaniel
6 years ago (2014-11-25 17:18:14 UTC) #2
robertphillips
lgtm
6 years ago (2014-11-25 17:40:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758973002/1
6 years ago (2014-11-25 17:58:20 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-25 18:08:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/74d80eba370557c22cebef6c3be0875c32e1b17b

Powered by Google App Engine
This is Rietveld 408576698