Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Issue 758943002: android: don't try to handle suppress_wildcard. (Closed)

Created:
6 years ago by Torne
Modified:
6 years ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

android: don't try to handle suppress_wildcard. When deciding whether to include a target in the generated makefiles or not, don't consider the suppress_wildcard flag as this just means that any target which depends directly on the target in question will crash gyp. The exact contents of the "all" target on the android backend are not really relevant, so this is the simplest fix. BUG=chromium:435772 R=thakis@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=2010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M pylib/gyp/generator/android.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Torne
Well, this is the fix for the bug, but apparently the gyp-android bot has been ...
6 years ago (2014-11-25 15:59:32 UTC) #2
Nico
lgtm to get things unblocked. Test, and a working bot would be nice :-)
6 years ago (2014-11-25 16:44:53 UTC) #3
Torne
On 2014/11/25 16:44:53, Nico wrote: > lgtm to get things unblocked. Test, and a working ...
6 years ago (2014-11-25 16:50:54 UTC) #4
Torne
Having one more go at trying this (with a clobber) and if the bot still ...
6 years ago (2014-11-27 16:16:43 UTC) #5
Torne
Committed patchset #1 (id:1) manually as 2010 (presubmit successful).
6 years ago (2014-11-27 16:56:59 UTC) #6
Torne
6 years ago (2014-11-27 16:59:36 UTC) #7
Message was sent while issue was closed.
Bot still broken. We'll investigate separately.

Powered by Google App Engine
This is Rietveld 408576698