Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 758853005: Remove Initialize/Shutdown from DriSurfaceFactory (Closed)

Created:
6 years ago by dnicoara
Modified:
6 years ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove Initialize/Shutdown from DriSurfaceFactory DriSurfaceFactory no longer does any meaningful initialization. Remove redundant code. BUG=none NOTRY=true Committed: https://crrev.com/b4c4ef989e31d23d683bdef5f0c79de0a3d3ea60 Cr-Commit-Position: refs/heads/master@{#307081}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -182 lines) Patch
M ui/ozone/platform/dri/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/dri.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_surface_factory.h View 1 2 chunks +0 lines, -17 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface_factory.cc View 1 1 chunk +1 line, -27 lines 0 comments Download
D ui/ozone/platform/dri/dri_surface_factory_unittest.cc View 1 chunk +0 lines, -119 lines 0 comments Download
M ui/ozone/platform/dri/dri_window_delegate_impl_unittest.cc View 1 3 chunks +7 lines, -8 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surface_factory.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_dri.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_gbm.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dnicoara
PTAL
6 years ago (2014-12-05 20:57:44 UTC) #2
spang
lgtm
6 years ago (2014-12-05 20:59:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758853005/40001
6 years ago (2014-12-05 21:12:39 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-05 21:13:30 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-05 21:14:58 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b4c4ef989e31d23d683bdef5f0c79de0a3d3ea60
Cr-Commit-Position: refs/heads/master@{#307081}

Powered by Google App Engine
This is Rietveld 408576698