Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 758843004: Delete most of rendering/compositing. (Closed)

Created:
6 years ago by ojan
Modified:
6 years ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Delete most of rendering/compositing. Particularly, this deletes RenderLayerCompositor. After this, there's just CompositingState left to remove. This is all dead code, so there should be no change in behavior. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3fe3f98be854c2d49450dff2b781d82b71dc69b1

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1644 lines) Patch
M sky/engine/core/animation/DocumentAnimations.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/core.gni View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/css/MediaQueryEvaluator.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/MediaValues.cpp View 2 chunks +2 lines, -6 lines 4 comments Download
M sky/engine/core/dom/Document.cpp View 4 chunks +1 line, -7 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/FrameView.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 7 chunks +2 lines, -26 lines 0 comments Download
M sky/engine/core/frame/LocalFrame.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/frame/LocalFrame.cpp View 2 chunks +0 lines, -16 lines 0 comments Download
M sky/engine/core/page/Page.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/page/Page.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 7 chunks +6 lines, -13 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 19 chunks +13 lines, -96 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.h View 2 chunks +1 line, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 3 chunks +0 lines, -27 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerStackingNode.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerStackingNode.cpp View 4 chunks +0 lines, -13 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 2 chunks +4 lines, -4 lines 2 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderView.h View 4 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 4 chunks +3 lines, -36 lines 0 comments Download
D sky/engine/core/rendering/compositing/CompositingReasonFinder.h View 1 chunk +0 lines, -42 lines 0 comments Download
D sky/engine/core/rendering/compositing/CompositingReasonFinder.cpp View 1 chunk +0 lines, -141 lines 0 comments Download
D sky/engine/core/rendering/compositing/CompositingTriggers.h View 1 chunk +0 lines, -37 lines 0 comments Download
D sky/engine/core/rendering/compositing/RenderLayerCompositor.h View 1 chunk +0 lines, -219 lines 0 comments Download
D sky/engine/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +0 lines, -620 lines 0 comments Download
M sky/engine/platform/graphics/GraphicsLayer.h View 2 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/platform/graphics/GraphicsLayer.cpp View 2 chunks +0 lines, -220 lines 0 comments Download
M sky/engine/public/web/WebFrame.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/web/PageWidgetDelegate.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebLocalFrameImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 3 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 4 chunks +1 line, -43 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ojan
https://codereview.chromium.org/758843004/diff/1/sky/engine/core/css/MediaValues.cpp File sky/engine/core/css/MediaValues.cpp (right): https://codereview.chromium.org/758843004/diff/1/sky/engine/core/css/MediaValues.cpp#newcode102 sky/engine/core/css/MediaValues.cpp:102: return true; I'm not sure if this should be ...
6 years ago (2014-11-26 19:38:51 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/758843004/diff/1/sky/engine/core/css/MediaValues.cpp File sky/engine/core/css/MediaValues.cpp (right): https://codereview.chromium.org/758843004/diff/1/sky/engine/core/css/MediaValues.cpp#newcode102 sky/engine/core/css/MediaValues.cpp:102: return true; On 2014/11/26 at 19:38:51, ojan wrote: ...
6 years ago (2014-11-26 19:48:36 UTC) #3
abarth-chromium
https://codereview.chromium.org/758843004/diff/1/sky/engine/core/css/MediaValues.cpp File sky/engine/core/css/MediaValues.cpp (right): https://codereview.chromium.org/758843004/diff/1/sky/engine/core/css/MediaValues.cpp#newcode102 sky/engine/core/css/MediaValues.cpp:102: return true; On 2014/11/26 at 19:48:36, abarth wrote: > ...
6 years ago (2014-11-26 19:48:58 UTC) #4
ojan
https://codereview.chromium.org/758843004/diff/1/sky/engine/core/css/MediaValues.cpp File sky/engine/core/css/MediaValues.cpp (right): https://codereview.chromium.org/758843004/diff/1/sky/engine/core/css/MediaValues.cpp#newcode102 sky/engine/core/css/MediaValues.cpp:102: return true; On 2014/11/26 at 19:48:58, abarth wrote: > ...
6 years ago (2014-11-26 23:13:03 UTC) #5
ojan
6 years ago (2014-11-26 23:15:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3fe3f98be854c2d49450dff2b781d82b71dc69b1.

Powered by Google App Engine
This is Rietveld 408576698