Issue 758813002: free up picturerecorder refs after returning picture or drawable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 758813002: free up picturerecorder refs after returning picture or drawable (Closed)

Created:
6 years ago by reed2

Modified:
6 years ago

Reviewers:
mtklein, robertphillips, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

free up picturerecorder refs after returning picture or drawable this just accelerates what would happen on the next beginRecording() call or the destructor. chrome has unittests that break (shaders on the stack) if we hold on to the internals past endRecording(). BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/26a6bf6a26b0e837377c876d74508aaefee72658

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -7 lines)			Patch
	M	include/core/SkPictureRecorder.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	src/core/SkPictureRecorder.cpp	View		4 chunks	+18 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758813002/1

6 years ago (2014-11-25 03:48:41 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/26a6bf6a26b0e837377c876d74508aaefee72658

6 years ago (2014-11-25 03:59:28 UTC) #5

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages