Enable boolean testing of scoped_refptr<T>.

Enable boolean testing of scoped_refptr<T>.

BUG=110610
Committed: https://crrev.com/5ab2ac7ac64528a00ba7f21d2ae4a14c070e84e8
Cr-Commit-Position: refs/heads/master@{#305763}

[dcheng, 2014-11-25 03:47:35]

dcheng@chromium.org changed reviewers:
+ danakj@chromium.org

[dcheng, 2014-11-25 08:44:36]

Yay!

https://codereview.chromium.org/758803002/diff/1/base/memory/ref_counted_unit...
File base/memory/ref_counted_unittest.cc (right):

https://codereview.chromium.org/758803002/diff/1/base/memory/ref_counted_unit...
base/memory/ref_counted_unittest.cc:100: EXPECT_NE(p1, p2);
This is primarily to ensure that we're not inadvertently converting both sides
to a Testable before doing the comparison.

https://codereview.chromium.org/758803002/diff/1/base/memory/ref_counted_unit...
base/memory/ref_counted_unittest.cc:104: TEST(RefCountedUnitTest,
ConvertibleEquality) {
shared_ptr allows comparisons between convertible types
(http://en.cppreference.com/w/cpp/memory/shared_ptr/operator_cmp), so I opted to
test that behavior explicitly here.

[dcheng, 2014-11-26 00:40:12]

dcheng@chromium.org changed reviewers:
+ thestig@chromium.org

[dcheng, 2014-11-26 00:40:12]

+thestig, mind taking a look?

[Lei Zhang, 2014-11-26 00:44:18]

lgtm

https://codereview.chromium.org/758803002/diff/1/base/memory/ref_counted.h
File base/memory/ref_counted.h (right):

https://codereview.chromium.org/758803002/diff/1/base/memory/ref_counted.h#ne...
base/memory/ref_counted.h:344: typedef T* scoped_refptr::*Testable;
nit: blank line after.

[dcheng, 2014-11-26 00:45:28]

https://codereview.chromium.org/758803002/diff/1/base/memory/ref_counted.h
File base/memory/ref_counted.h (right):

https://codereview.chromium.org/758803002/diff/1/base/memory/ref_counted.h#ne...
base/memory/ref_counted.h:344: typedef T* scoped_refptr::*Testable;
On 2014/11/26 00:44:18, Lei Zhang wrote:
> nit: blank line after.

Done.

[dcheng, 2014-11-26 00:45:31]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-11-26 00:47:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/758803002/20001

[commit-bot: I haz the power, 2014-11-26 02:35:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-26 02:36:07]

Patchset 2 (id:??) landed as
https://crrev.com/5ab2ac7ac64528a00ba7f21d2ae4a14c070e84e8
Cr-Commit-Position: refs/heads/master@{#305763}