gm/rebaseline_server/download_actuals.py - Issue 758793003: Tolerate unstarted builds in rebaseline server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/rebaseline_server/download_actuals.py

Issue 758793003: Tolerate unstarted builds in rebaseline server. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/rebaseline_server/download_actuals.py

diff --git a/gm/rebaseline_server/download_actuals.py b/gm/rebaseline_server/download_actuals.py

index 437b66328d4b60b90a8916f3160f443c6b9783ca..ae16770c494ba664442e15f3e196cdd70fb1f093 100755

--- a/gm/rebaseline_server/download_actuals.py

+++ b/gm/rebaseline_server/download_actuals.py

@@ -197,6 +197,9 @@ class RietveldIssueActuals(object):

logging.info('Fetching issue %s patch %s try %s...' %

(self._issue, patchset, try_builder))

build_url = try_job_result.get('url', '<bad url>')

+ if build_url is None:

+ logging.warning('Builder %s has not started.' % (try_builder,))

+ continue

gm_upload_output_url = build_url + urllib2.quote(upload_gm_step_url)

logging.info('Fetching %s ...' % (gm_upload_output_url,))

« no previous file with comments | « no previous file | no next file » | no next file with comments »