Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3653)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_view.cc

Issue 75873002: [SiteChip] Add the basic painting of the site chip button (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move painter, etc. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/toolbar_view.cc
diff --git a/chrome/browser/ui/views/toolbar/toolbar_view.cc b/chrome/browser/ui/views/toolbar/toolbar_view.cc
index 0df0bed6514691766823d571342e84d1ad3976ed..2b1b8d44267a2a18a340191c8e369093fb70ce0a 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_view.cc
+++ b/chrome/browser/ui/views/toolbar/toolbar_view.cc
@@ -37,6 +37,7 @@
#include "chrome/browser/ui/views/toolbar/browser_actions_container.h"
#include "chrome/browser/ui/views/toolbar/home_button.h"
#include "chrome/browser/ui/views/toolbar/reload_button.h"
+#include "chrome/browser/ui/views/toolbar/site_chip_view.h"
#include "chrome/browser/ui/views/toolbar/toolbar_button.h"
#include "chrome/browser/ui/views/toolbar/wrench_menu.h"
#include "chrome/browser/ui/views/toolbar/wrench_toolbar_button.h"
@@ -121,6 +122,7 @@ ToolbarView::ToolbarView(Browser* browser)
reload_(NULL),
home_(NULL),
location_bar_(NULL),
+ site_chip_view_(NULL),
browser_actions_(NULL),
app_menu_(NULL),
browser_(browser) {
@@ -227,6 +229,8 @@ void ToolbarView::Init() {
AddChildView(reload_);
AddChildView(home_);
AddChildView(location_bar_);
+ site_chip_view_ = new SiteChipView(this);
+ AddChildView(site_chip_view_);
AddChildView(browser_actions_);
AddChildView(app_menu_);
@@ -238,6 +242,7 @@ void ToolbarView::Init() {
UpdateAppMenuState();
location_bar_->Init();
+ site_chip_view_->Init();
show_home_button_.Init(prefs::kShowHomeButton,
browser_->profile()->GetPrefs(),
base::Bind(&ToolbarView::OnShowHomeButtonChanged,
@@ -266,6 +271,8 @@ void ToolbarView::OnWidgetVisibilityChanged(views::Widget* widget,
void ToolbarView::Update(WebContents* tab) {
if (location_bar_)
location_bar_->Update(tab);
+ if (site_chip_view_)
+ site_chip_view_->Update(tab);
if (browser_actions_)
browser_actions_->RefreshBrowserActionViews();
@@ -487,6 +494,10 @@ gfx::Size ToolbarView::GetPreferredSize() {
(show_home_button_.GetValue() ?
(home_->GetPreferredSize().width() + button_spacing) : 0) +
location_bar_->GetPreferredSize().width() +
+ (site_chip_view_->ShouldShow() ?
+ (site_chip_view_->GetPreferredSize().width() +
+ 2 * kSiteChipSpacing + 2 * button_spacing) :
+ 0) +
browser_actions_->GetPreferredSize().width() +
app_menu_->GetPreferredSize().width() + kRightEdgeSpacing;
gfx::ImageSkia* normal_background =
@@ -556,18 +567,41 @@ void ToolbarView::Layout() {
}
int browser_actions_width = browser_actions_->GetPreferredSize().width();
+
+ // Note: spacing from location bar to site chip is 1 pixel less than
+ // kStandardSpacing given the edge thickness of the chip.
+ int site_chip_width =
+ (site_chip_view_->ShouldShow() ?
+ site_chip_view_->GetPreferredSize().width() +
+ 2 * kSiteChipSpacing : 0);
int app_menu_width = app_menu_->GetPreferredSize().width();
int location_x = home_->x() + home_->width() + kStandardSpacing;
int available_width = std::max(0, width() - kRightEdgeSpacing -
app_menu_width - browser_actions_width - location_x);
+ // Cap site chip width at 1/2 the size available to the location bar.
+ site_chip_width = std::min(site_chip_width, available_width / 2);
+ available_width -= site_chip_width;
+
int location_height = location_bar_->GetPreferredSize().height();
int location_y = (height() - location_height + 1) / 2;
location_bar_->SetBounds(location_x, location_y, std::max(available_width, 0),
location_height);
- browser_actions_->SetBounds(location_bar_->x() + location_bar_->width(), 0,
+ int browser_actions_x = location_bar_->x() + location_bar_->width();
+
+ if (site_chip_view_->ShouldShow()) {
+ site_chip_view_->SetBounds(browser_actions_x + kSiteChipSpacing,
+ child_y,
+ site_chip_view_->GetPreferredSize().width(),
+ child_height);
+ browser_actions_x +=
+ site_chip_view_->GetPreferredSize().width() + kSiteChipSpacing;
+ }
+
+ browser_actions_->SetBounds(browser_actions_x, 0,
browser_actions_width, height());
+
// The browser actions need to do a layout explicitly, because when an
// extension is loaded/unloaded/changed, BrowserActionContainer removes and
// re-adds everything, regardless of whether it has a page action. For a

Powered by Google App Engine
This is Rietveld 408576698