Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 758643003: [turbofan] Insert appropriate conversions for typed array stores. (Closed)

Created:
6 years ago by Jarin
Modified:
6 years ago
CC:
Sven Panne, v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] Insert appropriate conversions for typed array stores. BUG=

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -77 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 1 chunk +30 lines, -4 lines 0 comments Download
M test/mjsunit/compiler/truncating-store.js View 1 chunk +94 lines, -69 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +50 lines, -1 line 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +6 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 3 chunks +57 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jarin
Could you take a look, please?
6 years ago (2014-11-24 21:17:59 UTC) #2
Benedikt Meurer
lgtm
6 years ago (2014-11-25 05:00:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758643003/20001
6 years ago (2014-11-25 08:12:11 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-25 08:40:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698