Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Unified Diff: sky/engine/core/dom/Element.cpp

Issue 758623002: Remove didNotifySubtreeInsertionsToDocument. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/Element.h ('k') | sky/engine/core/dom/Node.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/Element.cpp
diff --git a/sky/engine/core/dom/Element.cpp b/sky/engine/core/dom/Element.cpp
index cdf7e2e864e6d76998ed7a8b9dfdf1c2a73bfe63..b0b9340fb288705a4b994b8aa203a467f6c2c158 100644
--- a/sky/engine/core/dom/Element.cpp
+++ b/sky/engine/core/dom/Element.cpp
@@ -757,27 +757,25 @@ RenderObject* Element::createRenderer(RenderStyle* style)
return RenderObject::createObject(this, style);
}
-Node::InsertionNotificationRequest Element::insertedInto(ContainerNode* insertionPoint)
+void Element::insertedInto(ContainerNode* insertionPoint)
{
// need to do superclass processing first so inDocument() is true
// by the time we reach updateId
ContainerNode::insertedInto(insertionPoint);
if (!insertionPoint->isInTreeScope())
- return InsertionDone;
+ return;
if (isUpgradedCustomElement() && inDocument())
CustomElement::didAttach(this, document());
TreeScope& scope = insertionPoint->treeScope();
if (scope != treeScope())
- return InsertionDone;
+ return;
const AtomicString& idValue = getIdAttribute();
if (!idValue.isNull())
updateId(scope, nullAtom, idValue);
-
- return InsertionDone;
}
void Element::removedFrom(ContainerNode* insertionPoint)
« no previous file with comments | « sky/engine/core/dom/Element.h ('k') | sky/engine/core/dom/Node.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698