Do not reflect uninitialized 'let' and 'const' in scope mirrors.

Do not reflect uninitialized 'let' and 'const' in scope mirrors.

R=yangguo@chromium.org,aandrey@chromium.org
BUG=v8:3743
LOG=N

[Dmitry Lomov (no reviews), 2014-12-08 11:44:11]

PTAL

[Yang, 2014-12-08 12:46:10]

On 2014/12/08 11:44:11, Dmitry Lomov (chromium) wrote:
> PTAL

lgtm.

[aandrey, 2014-12-08 13:12:23]

lgtm

https://codereview.chromium.org/758603004/diff/1/test/mjsunit/harmony/debug-b...
File test/mjsunit/harmony/debug-blockscopes.js (right):

https://codereview.chromium.org/758603004/diff/1/test/mjsunit/harmony/debug-b...
test/mjsunit/harmony/debug-blockscopes.js:501: CheckScopeContent({}, 0,
exec_state);
DevTools will not show empty Block scopes. Should I change this on our side?

[Dmitry Lomov (no reviews), 2014-12-08 14:34:09]

https://codereview.chromium.org/758603004/diff/1/test/mjsunit/harmony/debug-b...
File test/mjsunit/harmony/debug-blockscopes.js (right):

https://codereview.chromium.org/758603004/diff/1/test/mjsunit/harmony/debug-b...
test/mjsunit/harmony/debug-blockscopes.js:501: CheckScopeContent({}, 0,
exec_state);
On 2014/12/08 13:12:22, aandrey wrote:
> DevTools will not show empty Block scopes. Should I change this on our side?

I do not know what is best here. This change makes variables invisible if you
break before the declaration. I think it is fine if we just not show empty block
scopes.

Another option would be to add not-yet-defined variables to block scopes with
'undefined' value.

[Dmitry Lomov (no reviews), 2014-12-08 14:34:12]

The CQ bit was checked by dslomov@chromium.org

[commit-bot: I haz the power, 2014-12-08 14:34:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/758603004/1

[commit-bot: I haz the power, 2014-12-08 14:59:15]

Committed patchset #1 (id:1)