Issue 758603003: [turbofan] Combine additional Word32And with Int32Add and negative power of two.

Issue 758603003: [turbofan] Combine additional Word32And with Int32Add and negative power of two. (Closed)

Created:
6 years ago by Benedikt Meurer

Modified:
6 years ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Combine additional Word32And with Int32Add and negative power of two. - (y << L + x) & (-1 << L) => (x & (-1 << L)) + y << L - (x + y << L) & (-1 << L) => (x & (-1 << L)) + y << L TEST=unittests R=jarin@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/2983d84e5cae739fd1762013c4be43b383be68f1

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -3 lines)			Patch
	M	src/compiler/machine-operator-reducer.cc	View		1 chunk	+25 lines, -1 line	0 comments	Download
	M	test/unittests/compiler/machine-operator-reducer-unittest.cc	View	1	2 chunks	+21 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jarin

lgtm https://codereview.chromium.org/758603003/diff/1/test/unittests/compiler/machine-operator-reducer-unittest.cc File test/unittests/compiler/machine-operator-reducer-unittest.cc (right): https://codereview.chromium.org/758603003/diff/1/test/unittests/compiler/machine-operator-reducer-unittest.cc#newcode535 test/unittests/compiler/machine-operator-reducer-unittest.cc:535: Node* const p1 = Parameter(0); Not that it ...

6 years ago (2014-12-03 07:33:13 UTC) #3

Benedikt Meurer

https://codereview.chromium.org/758603003/diff/1/test/unittests/compiler/machine-operator-reducer-unittest.cc File test/unittests/compiler/machine-operator-reducer-unittest.cc (right): https://codereview.chromium.org/758603003/diff/1/test/unittests/compiler/machine-operator-reducer-unittest.cc#newcode535 test/unittests/compiler/machine-operator-reducer-unittest.cc:535: Node* const p1 = Parameter(0); On 2014/12/03 07:33:13, jarin ...

6 years ago (2014-12-03 07:34:34 UTC) #4

Benedikt Meurer

6 years ago (2014-12-03 07:35:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
2983d84e5cae739fd1762013c4be43b383be68f1 (tree was closed).

Expand Messages | Collapse Messages