Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: content/renderer/notification_permission_dispatcher.h

Issue 758603002: Use Mojo Permission Service when requesting Notifications permission. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission_geolocation_follow_up
Patch Set: fixes to pass tests Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/notification_permission_dispatcher.h
diff --git a/content/renderer/notification_permission_dispatcher.h b/content/renderer/notification_permission_dispatcher.h
index c01b0632784ed66f1a5a857c8ca63f3769e9caaf..5c32693b18a7295e3a1fb12cbd14f7b3b9efddcd 100644
--- a/content/renderer/notification_permission_dispatcher.h
+++ b/content/renderer/notification_permission_dispatcher.h
@@ -6,9 +6,8 @@
#define CONTENT_RENDERER_NOTIFICATION_PERMISSION_DISPATCHER_H_
#include "base/id_map.h"
+#include "content/common/permission_service.mojom.h"
#include "content/public/renderer/render_frame_observer.h"
-#include "ipc/ipc_message.h"
-#include "third_party/WebKit/public/platform/WebNotificationPermission.h"
namespace blink {
class WebNotificationPermissionCallback;
@@ -31,17 +30,16 @@ class NotificationPermissionDispatcher : public RenderFrameObserver {
blink::WebNotificationPermissionCallback* callback);
private:
- // RenderFrameObserver implementation.
- bool OnMessageReceived(const IPC::Message& message) override;
-
void OnPermissionRequestComplete(
- int request_id, blink::WebNotificationPermission result);
+ int request_id, PermissionStatus status);
// Tracks the active notification permission requests. This class takes
// ownership of the created WebNotificationPermissionCallback objects.
IDMap<blink::WebNotificationPermissionCallback, IDMapOwnPointer>
pending_requests_;
+ PermissionServicePtr permission_service_;
+
DISALLOW_COPY_AND_ASSIGN(NotificationPermissionDispatcher);
};
« no previous file with comments | « content/common/platform_notification_messages.h ('k') | content/renderer/notification_permission_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698