Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: sky/engine/core/css/StyleSheetContents.h

Issue 758573005: Remove CSSOM mutability in StyleRule. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/css/StyleRuleKeyframes.cpp ('k') | sky/engine/core/css/StyleSheetContents.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/css/StyleSheetContents.h
diff --git a/sky/engine/core/css/StyleSheetContents.h b/sky/engine/core/css/StyleSheetContents.h
index 7fecc8001c03169aeb0a848722c54e8d2a7d3c61..375fd73105f938ccad5a74bf3d1d1494b9632808 100644
--- a/sky/engine/core/css/StyleSheetContents.h
+++ b/sky/engine/core/css/StyleSheetContents.h
@@ -72,10 +72,6 @@ public:
void setHasSyntacticallyValidCSSHeader(bool isValidCss);
bool hasSyntacticallyValidCSSHeader() const { return m_hasSyntacticallyValidCSSHeader; }
- void setHasFontFaceRule(bool b) { m_hasFontFaceRule = b; }
- bool hasFontFaceRule() const { return m_hasFontFaceRule; }
- void findFontFaceRules(Vector<RawPtr<const StyleRuleFontFace> >& fontFaceRules);
-
void parserAppendRule(PassRefPtr<StyleRuleBase>);
void parserSetUsesRemUnits(bool b) { m_usesRemUnits = b; }
@@ -95,35 +91,16 @@ public:
bool usesRemUnits() const { return m_usesRemUnits; }
- unsigned estimatedSizeInBytes() const;
-
- bool wrapperInsertRule(PassRefPtr<StyleRuleBase>, unsigned index);
- void wrapperDeleteRule(unsigned index);
-
- PassRefPtr<StyleSheetContents> copy() const
- {
- return adoptRef(new StyleSheetContents(*this));
- }
-
void registerClient(CSSStyleSheet*);
void unregisterClient(CSSStyleSheet*);
size_t clientSize() const { return m_loadingClients.size() + m_completedClients.size(); }
bool hasOneClient() const { return clientSize() == 1; }
- bool isMutable() const { return m_isMutable; }
- void setMutable() { m_isMutable = true; }
-
void removeSheetFromCache(Document*);
- bool isInMemoryCache() const { return m_isInMemoryCache; }
- void addedToMemoryCache();
- void removedFromMemoryCache();
-
void setHasMediaQueries();
bool hasMediaQueries() const { return m_hasMediaQueries; }
- bool didLoadErrorOccur() const { return m_didLoadErrorOccur; }
-
void shrinkToFit();
RuleSet& ruleSet() { ASSERT(m_ruleSet); return *m_ruleSet.get(); }
RuleSet& ensureRuleSet(const MediaQueryEvaluator&, AddRuleFlags);
@@ -131,33 +108,24 @@ public:
private:
StyleSheetContents(const String& originalURL, const CSSParserContext&);
- StyleSheetContents(const StyleSheetContents&);
+
void notifyRemoveFontFaceRule(const StyleRuleFontFace*);
Document* clientSingleOwnerDocument() const;
- String m_originalURL;
-
- Vector<RefPtr<StyleRuleBase> > m_childRules;
- typedef HashMap<AtomicString, AtomicString> PrefixNamespaceURIMap;
- PrefixNamespaceURIMap m_namespaces;
-
bool m_hasSyntacticallyValidCSSHeader : 1;
- bool m_didLoadErrorOccur : 1;
bool m_usesRemUnits : 1;
- bool m_isMutable : 1;
- bool m_isInMemoryCache : 1;
- bool m_hasFontFaceRule : 1;
bool m_hasMediaQueries : 1;
bool m_hasSingleOwnerDocument : 1;
+ String m_originalURL;
+ OwnPtr<RuleSet> m_ruleSet;
+ Vector<RefPtr<StyleRuleBase> > m_childRules;
CSSParserContext m_parserContext;
HashSet<RawPtr<CSSStyleSheet> > m_loadingClients;
HashSet<RawPtr<CSSStyleSheet> > m_completedClients;
typedef HashSet<RawPtr<CSSStyleSheet> >::iterator ClientsIterator;
-
- OwnPtr<RuleSet> m_ruleSet;
};
} // namespace
« no previous file with comments | « sky/engine/core/css/StyleRuleKeyframes.cpp ('k') | sky/engine/core/css/StyleSheetContents.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698