Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 758573005: Remove CSSOM mutability in StyleRule. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
eseidel, ojan
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove CSSOM mutability in StyleRule. The StyleRule classes supported copy() operations and mutable property sets so that we could do copy-on-write and mutate them using the CSSOM. Sky doesn't have a CSSOM like this though, so we can remove all this code and make the StyleRule classes effectively immutable after construction (the parser does mutate some rules though). I also removed some other dead code in the StyleRule hierarchy, like some left over mutation methods that the CSSOM used to use. R=eseidel@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2d17d1e99a5581d87023e2df62745b59f6558b32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -324 lines) Patch
M sky/engine/core/css/StyleKeyframe.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/StyleKeyframe.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/css/StyleRule.h View 9 chunks +11 lines, -31 lines 0 comments Download
M sky/engine/core/css/StyleRule.cpp View 5 chunks +0 lines, -97 lines 0 comments Download
M sky/engine/core/css/StyleRuleKeyframes.h View 4 chunks +2 lines, -7 lines 0 comments Download
M sky/engine/core/css/StyleRuleKeyframes.cpp View 2 chunks +0 lines, -35 lines 0 comments Download
M sky/engine/core/css/StyleSheetContents.h View 3 chunks +4 lines, -36 lines 0 comments Download
M sky/engine/core/css/StyleSheetContents.cpp View 5 chunks +2 lines, -103 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
esprehn
6 years ago (2014-12-03 23:00:50 UTC) #2
eseidel
lgtm You really don't write much in your descriptions do you...
6 years ago (2014-12-03 23:02:14 UTC) #3
ojan
lgtm
6 years ago (2014-12-03 23:03:48 UTC) #4
esprehn
6 years ago (2014-12-03 23:54:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2d17d1e99a5581d87023e2df62745b59f6558b32 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698