Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: Source/core/animation/InterpolableValue.h

Issue 758533004: Oilpan: enable eager tracing of common animation objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sof-trace-eager-final
Patch Set: rebased Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/AnimationStack.h ('k') | Source/core/animation/Interpolation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/InterpolableValue.h
diff --git a/Source/core/animation/InterpolableValue.h b/Source/core/animation/InterpolableValue.h
index bc9a009347e923012488fffc0746c5ed011366cf..69bb1a2bb6256fa8e2f547e1c54f7515375e5710 100644
--- a/Source/core/animation/InterpolableValue.h
+++ b/Source/core/animation/InterpolableValue.h
@@ -6,6 +6,7 @@
#define InterpolableValue_h
#include "core/animation/animatable/AnimatableValue.h"
+#include "platform/heap/Handle.h"
#include "wtf/OwnPtr.h"
#include "wtf/PassOwnPtr.h"
#include "wtf/Vector.h"
@@ -37,7 +38,9 @@ private:
friend class InterpolableList;
};
-class InterpolableNumber : public InterpolableValue {
+WILL_BE_EAGERLY_TRACED(InterpolableValue);
+
+class InterpolableNumber final : public InterpolableValue {
public:
static PassOwnPtrWillBeRawPtr<InterpolableNumber> create(double value)
{
@@ -48,8 +51,6 @@ public:
double value() const { return m_value; }
virtual PassOwnPtrWillBeRawPtr<InterpolableValue> clone() const override final { return create(m_value); }
- virtual void trace(Visitor* visitor) override { InterpolableValue::trace(visitor); }
-
private:
virtual void interpolate(const InterpolableValue& to, const double progress, InterpolableValue& result) const override final;
double m_value;
@@ -61,7 +62,7 @@ private:
};
-class InterpolableBool : public InterpolableValue {
+class InterpolableBool final : public InterpolableValue {
public:
static PassOwnPtrWillBeRawPtr<InterpolableBool> create(bool value)
{
@@ -72,8 +73,6 @@ public:
bool value() const { return m_value; }
virtual PassOwnPtrWillBeRawPtr<InterpolableValue> clone() const override final { return create(m_value); }
- virtual void trace(Visitor* visitor) override { InterpolableValue::trace(visitor); }
-
private:
virtual void interpolate(const InterpolableValue& to, const double progress, InterpolableValue& result) const override final;
bool m_value;
« no previous file with comments | « Source/core/animation/AnimationStack.h ('k') | Source/core/animation/Interpolation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698