Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 758523006: Revert of rebaselines (Closed)

Created:
6 years ago by Tom Hudson
Modified:
6 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of rebaselines (patchset #1 id:1 of https://codereview.chromium.org/753133003/) Reason for revert: Reverted causative patch (https://codereview.chromium.org/747043004) Original issue's description: > rebaselines > > NOTRY=true > NOTREECHECKS=true > TBR= > > Committed: https://skia.googlesource.com/skia/+/65ba7b57759bfca60b24bc34dc46fc8caaf146f0 TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Messages

Total messages: 4 (1 generated)
Tom Hudson
Created Revert of rebaselines
6 years ago (2014-11-24 19:23:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758523006/1
6 years ago (2014-11-24 19:24:36 UTC) #2
commit-bot: I haz the power
6 years ago (2014-11-24 19:24:41 UTC) #4
Failed to apply patch for
expectations/gm/Test-Android-GalaxyS4-SGX544-Arm7-Debug/expected-results.json:
While running git apply --index -3 -p1;
  error: patch failed:
expectations/gm/Test-Android-GalaxyS4-SGX544-Arm7-Debug/expected-results.json:5852
  Falling back to three-way merge...
  Applied patch to
'expectations/gm/Test-Android-GalaxyS4-SGX544-Arm7-Debug/expected-results.json'
with conflicts.
  U
expectations/gm/Test-Android-GalaxyS4-SGX544-Arm7-Debug/expected-results.json

Patch:      
expectations/gm/Test-Android-GalaxyS4-SGX544-Arm7-Debug/expected-results.json
Index:
expectations/gm/Test-Android-GalaxyS4-SGX544-Arm7-Debug/expected-results.json
diff --git
a/expectations/gm/Test-Android-GalaxyS4-SGX544-Arm7-Debug/expected-results.json
b/expectations/gm/Test-Android-GalaxyS4-SGX544-Arm7-Debug/expected-results.json
index
e12422270dd8bccecd373fc971feeec87a263876..f6bd4ab5a15a37b6dc88ee57701769ceb7d597f4
100644
---
a/expectations/gm/Test-Android-GalaxyS4-SGX544-Arm7-Debug/expected-results.json
+++
b/expectations/gm/Test-Android-GalaxyS4-SGX544-Arm7-Debug/expected-results.json
@@ -3857,7 +3857,7 @@
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          18165407505633347407
+          4938590834664658305
         ]
       ], 
       "reviewed-by-human": true
@@ -5852,7 +5852,7 @@
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          9412995609628467341
+          17492314805851855065
         ]
       ], 
       "reviewed-by-human": true
@@ -5970,7 +5970,7 @@
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          9298514044054867967
+          571194008531839949
         ]
       ], 
       "ignore-failure": false,

Powered by Google App Engine
This is Rietveld 408576698