Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: src/debug.cc

Issue 758523004: Correctly find shared function info for debugging when compiling eagerly. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-3717.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index 86bfbbcb643475ce65fd8dfaae5384ccaa052f54..d8844cc414e3f03c64f803dac22fdfaa8c5a003f 100644
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -2121,7 +2121,10 @@ Object* Debug::FindSharedFunctionInfoInScript(Handle<Script> script,
Heap* heap = isolate_->heap();
while (!done) {
{ // Extra scope for iterator.
- HeapIterator iterator(heap);
+ // If lazy compilation is off, we won't have duplicate shared function
+ // infos that need to be filtered.
+ HeapIterator iterator(heap, FLAG_lazy ? HeapIterator::kNoFiltering
+ : HeapIterator::kFilterUnreachable);
for (HeapObject* obj = iterator.next();
obj != NULL; obj = iterator.next()) {
bool found_next_candidate = false;
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-3717.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698