Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 758523004: Correctly find shared function info for debugging when compiling eagerly. (Closed)

Created:
6 years ago by Yang
Modified:
6 years ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Correctly find shared function info for debugging when compiling eagerly. R=ulan@chromium.org BUG=v8:3717 LOG=N

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M src/debug.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-3717.js View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Yang
6 years ago (2014-11-24 12:15:36 UTC) #1
ulan
lgtm
6 years ago (2014-11-24 12:16:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758523004/20001
6 years ago (2014-11-24 14:16:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/1382)
6 years ago (2014-11-24 14:42:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758523004/40001
6 years ago (2014-11-24 15:15:31 UTC) #10
commit-bot: I haz the power
6 years ago (2014-11-24 15:43:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001)

Powered by Google App Engine
This is Rietveld 408576698