Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(506)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/fast/dynamic/first-child-descendant.html
Issue
758523002
:
Store :last/first-child state as restyle flags. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed assert
Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/fast/animation/last-child-assert.html
LayoutTests/fast/animation/last-child-assert-expected.html
LayoutTests/fast/dynamic/first-child-descendant.html
LayoutTests/fast/dynamic/first-child-descendant-expected.txt
LayoutTests/fast/dynamic/first-child-display-none.html
LayoutTests/fast/dynamic/first-child-display-none-expected.txt
LayoutTests/fast/dynamic/last-child-descendant.html
LayoutTests/fast/dynamic/last-child-descendant-expected.txt
LayoutTests/fast/dynamic/last-child-display-none.html
LayoutTests/fast/dynamic/last-child-display-none-expected.txt
LayoutTests/fast/dynamic/only-child.html
LayoutTests/fast/dynamic/only-child-expected.html
Source/core/css/SelectorChecker.cpp
Source/core/dom/ContainerNode.h
Source/core/dom/ContainerNode.cpp
Source/core/rendering/style/RenderStyle.h
View unified diff
|
Download patch
« no previous file with comments
|
« LayoutTests/fast/animation/last-child-assert-expected.html
('k') |
LayoutTests/fast/dynamic/first-child-descendant-expected.txt »
('j') |
Source/core/dom/ContainerNode.cpp »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<script src="../../resources/js-test.js"></script>
3
<style>
4
#b { color: green; }
5
#a:first-child #b { color: red }
6
</style>
7
<div id="t">
8
<div id="a">
9
<div id="b">This text should be green</div>
10
</div>
11
</div>
12
<script>
13
description("Evaluation of :first-child affecting descendant.");
14
15
t.offsetTop;
16
a.style.backgroundColor = "white";
17
t.offsetTop;
18
t.insertBefore(document.createElement("div"), a);
19
20
var green = "rgb(0, 128, 0)";
21
22
shouldBe("getComputedStyle(b).color", "green");
23
</script>
OLD
NEW
« no previous file with comments
|
« LayoutTests/fast/animation/last-child-assert-expected.html
('k') |
LayoutTests/fast/dynamic/first-child-descendant-expected.txt »
('j') |
Source/core/dom/ContainerNode.cpp »
('J')
Issue 758523002: Store :last/first-child state as restyle flags. (Closed)
Created 6 years ago by rune
Modified 6 years ago
Reviewers: esprehn
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Comments: 3
This is Rietveld
408576698
Chromium Code Reviews
Issue 758523002:
Store :last/first-child state as restyle flags. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master