canvas: make a temporary buffer when a context doesn't exist.

Source/core/editing/Editor.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 403 matching lines @@
         pasteAsFragment(fragment, canSmartReplaceWithPasteboard(pasteboard), chosePlainText);
 }
 
 void Editor::writeSelectionToPasteboard(Pasteboard* pasteboard, Range* selectedRange, const String& plainText)
 {
     String html = createMarkup(selectedRange, 0, AnnotateForInterchange, false, ResolveNonLocalURLs);
     KURL url = selectedRange->startContainer()->document().url();
     pasteboard->writeHTML(html, url, plainText, canSmartCopyOrDelete());
 }
 
-static Image* imageFromNode(const Node& node)
+static PassRefPtr<Image> imageFromNode(const Node& node)
 {
     node.document().updateLayoutIgnorePendingStylesheets();
     RenderObject* renderer = node.renderer();
     if (!renderer)
         return nullptr;
 
     if (renderer->isCanvas())
         return toHTMLCanvasElement(node).copiedImage(FrontBuffer);

[dshwang, 2014/12/01 14:31:12]

This line return PassRefPtr<Image> so this function must return PassRefPtr not
to return dangling pointer.
In addition, below cachedImage->imageForRenderer() returns PassRefPtr also.

[Justin Novosad, 2014/12/02 15:48:16]

I was thinking that this could be done in an oilpan friendly way by using
PassRefPtrWillBeRawPtr.  Then, I did some digging in the code and realize that
such a change would propagate very deep and should probably go into a separate
CL. So I am fine with this for now.

 
     if (renderer->isImage()) {
         RenderImage* renderImage = toRenderImage(renderer);
         if (!renderImage)
             return nullptr;
 
         ImageResource* cachedImage = renderImage->cachedImage();
         if (!cachedImage || cachedImage->errorOccurred())
             return nullptr;
         return cachedImage->imageForRenderer(renderImage);
@@ skipping 836 matching lines @@
 }
 
 void Editor::trace(Visitor* visitor)
 {
     visitor->trace(m_frame);
     visitor->trace(m_lastEditCommand);
     visitor->trace(m_mark);
 }
 
 } // namespace blink