Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 758473002: Fix some android configuration (Closed)

Created:
6 years, 1 month ago by cjhopman
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix some android configuration This adds //chrome/test:test_support_unit to the root build targets for Android. This target is used by downstream things and so adding it to the root will ensure that it is buildable upstream. This requires making the sync integration/performance stuff be not defined if !is_android (since they depend on things that aren't defined on that platform). Changes the internal configuration hooks to not require setting the sdk information. Makes unittest_apk actually forward datadeps. BUG=359249 TBR=cpu Committed: https://crrev.com/907644b0a7ddae52e3ef74a670df647fe61da5d9 Cr-Commit-Position: refs/heads/master@{#307589}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1

Patch Set 3 : also fix unittest datadeps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -169 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/config/android/config.gni View 1 1 chunk +3 lines, -1 line 0 comments Download
M build/config/android/rules.gni View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 chunks +168 lines, -166 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
cjhopman
https://codereview.chromium.org/758473002/diff/20001/chrome/test/BUILD.gn File chrome/test/BUILD.gn (right): https://codereview.chromium.org/758473002/diff/20001/chrome/test/BUILD.gn#newcode223 chrome/test/BUILD.gn:223: source_set("sync_integration_test_support") { Ugh, Rietveld diff for everything below this ...
6 years ago (2014-12-08 03:12:11 UTC) #1
cjhopman
cpu: *
6 years ago (2014-12-08 03:12:24 UTC) #3
cpu_(ooo_6.6-7.5)
now that owners have landed you can remove me and add somebody else.
6 years ago (2014-12-09 01:30:51 UTC) #4
cjhopman
newt: build/ sky: chrome/
6 years ago (2014-12-09 02:36:26 UTC) #6
newt (away)
lgtm
6 years ago (2014-12-09 03:32:58 UTC) #7
sky
LGTM
6 years ago (2014-12-09 16:53:12 UTC) #8
cjhopman
cpu: TBRed for the 1-line change in //BUILD.gn
6 years ago (2014-12-09 23:51:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758473002/40001
6 years ago (2014-12-09 23:52:53 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-10 00:01:27 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-10 00:02:20 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/907644b0a7ddae52e3ef74a670df647fe61da5d9
Cr-Commit-Position: refs/heads/master@{#307589}

Powered by Google App Engine
This is Rietveld 408576698