Push API: Store push registration IDs for GetRegistration etc

content/public/common/push_messaging_status.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_PUSH_MESSAGING_STATUS_H_
 #define CONTENT_PUBLIC_COMMON_PUSH_MESSAGING_STATUS_H_
 
 namespace content {
 
 // Push registration success / error codes for internal use & reporting in UMA.
@@ skipping 13 matching lines @@
 
   // Registration failed because permission was denied.
   PUSH_REGISTRATION_STATUS_PERMISSION_DENIED = 4,
 
   // Registration failed in the push service implemented by the embedder.
   PUSH_REGISTRATION_STATUS_SERVICE_ERROR = 5,
 
   // Registration failed because no sender id was provided by the page.
   PUSH_REGISTRATION_STATUS_NO_SENDER_ID = 6,
 
+  // Registration suceeded, but we failed to persist it.

[Avi (use Gerrit), 2014/12/05 20:50:22]

s/suceeded/succeeded/

[johnme, 2014/12/05 21:56:33]

Done.

+  PUSH_REGISTRATION_STATUS_STORAGE_ERROR = 7,

[Avi (use Gerrit), 2014/12/05 20:50:22]

I'm curious: if a registration succeeded but wasn't persisted, is it a useful
registration? What is the caller supposed to do upon getting this reply?

[johnme, 2014/12/05 21:56:33]

As well as it being one of the outcomes we log to UMA (to detect failure modes),
the caller will bubble up the error to JavaScript. The spec says[1] to fire a
DOMException whose `name` is "AbortError" for an errors that occur during
registration. But we'll set the `message`[2] of the DOMException to the string
produced by content::PushRegistrationStatusToString.

Thus a web developer who encounters this error
a) might be better able to guess at the cause,
b) can include it on stackoverflow and bug reports etc,
c) they or we will then be able to grep through the chromium source to find the
relevant code.

[1]:
https://w3c.github.io/push-api/#widl-PushRegistrationManager-register-Promise...

[2]: http://heycam.github.io/webidl/#dfn-exception-message

+
   // NOTE: Do not renumber these as that would confuse interpretation of
   // previously logged data. When making changes, also update the enum list
   // in tools/metrics/histograms/histograms.xml to keep it in sync, and
   // update PUSH_REGISTRATION_STATUS_LAST below.
 
   // Used for IPC message range checks.
-  PUSH_REGISTRATION_STATUS_LAST = PUSH_REGISTRATION_STATUS_NO_SENDER_ID
+  PUSH_REGISTRATION_STATUS_LAST = PUSH_REGISTRATION_STATUS_STORAGE_ERROR
 };
 
 // Push message delivery success / error codes for internal use.
 enum PushDeliveryStatus {
   // The message was successfully delivered.
   PUSH_DELIVERY_STATUS_SUCCESS,
 
   // The message could not be delivered because no service worker was found.
   PUSH_DELIVERY_STATUS_NO_SERVICE_WORKER,
 
   // The message could not be delivered because of a service worker error.
   PUSH_DELIVERY_STATUS_SERVICE_WORKER_ERROR,
 
   // The message was delivered, but the Service Worker passed a Promise to
   // event.waitUntil that got rejected.
   PUSH_DELIVERY_STATUS_EVENT_WAITUNTIL_REJECTED,
 
   // When making changes, update PUSH_DELIVERY_STATUS_LAST below.
 
   // Used for IPC message range checks.
   PUSH_DELIVERY_STATUS_LAST = PUSH_DELIVERY_STATUS_EVENT_WAITUNTIL_REJECTED
 };
 
 const char* PushRegistrationStatusToString(PushRegistrationStatus status);
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_PUSH_MESSAGING_STATUS_H_