Chromium Code Reviews

Issue 758343002: Add type annotations to gallery/js/image_editor/filter.js. (Closed)

Created:
6 years ago by yawano
Modified:
6 years ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add type annotations to gallery/js/image_editor/filter.js. BUG=433728 TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/gallery/js/compiled_resources.gyp && ninja -C out/Default | grep "filter.js" Committed: https://crrev.com/e732b712217b2652d6b1f7830d89ae4d49ce7aaf Cr-Commit-Position: refs/heads/master@{#305787}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+48 lines, -42 lines)
M ui/file_manager/gallery/js/image_editor/filter.js View 20 chunks +48 lines, -42 lines 0 comments

Messages

Total messages: 8 (2 generated)
yawano
@fukino: PTAL. Thanks!
6 years ago (2014-11-26 01:41:55 UTC) #2
fukino
On 2014/11/26 01:41:55, yawano wrote: > @fukino: PTAL. Thanks! lgtm. Thanks!
6 years ago (2014-11-26 04:22:56 UTC) #3
yawano
Thank you for the review!
6 years ago (2014-11-26 04:28:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758343002/1
6 years ago (2014-11-26 04:29:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-26 05:12:57 UTC) #7
commit-bot: I haz the power
6 years ago (2014-11-26 05:13:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e732b712217b2652d6b1f7830d89ae4d49ce7aaf
Cr-Commit-Position: refs/heads/master@{#305787}

Powered by Google App Engine