Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(56)

Issue 7583050: Adding a dependency on code.google.com/p/v8-i18n library. (Closed)

Created:
9 years, 7 months ago by Nebojša Ćirić
Modified:
9 years, 7 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews, darin (slow to review), Mads Ager (chromium)
Visibility:
Public.

Description

Adding a dependency on code.google.com/p/v8-i18n library. We've moved our i18n library from v8/src/extensions/experimental to a separate code.google.com project. Some files were renamed, and gyp file was cleaned up. We will update webkit tree once this DEPS change propagates to chromium port of WebKit. Pros: - Faster development cycle - Makes easier for v8 team to handle merges and rolls to chromium - Library uses only public v8 API so we don't expect breakages Cons: - Library is not so visible now that's outside of v8 tree Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96577

Patch Set 1 #

Patch Set 2 : Hardcode google code url until we set up the svn mirror. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M DEPS View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nebojša Ćirić
Short update on our status: 2 weeks ago we had a meeting with Microsoft, Amazon ...
9 years, 7 months ago (2011-08-10 21:22:43 UTC) #1
jungshik at Google
LGTM. Can you describe all 4 steps (including the final removal of i18n stuff from ...
9 years, 7 months ago (2011-08-10 21:30:00 UTC) #2
Nebojša Ćirić
1. Add DEPS to v8-i18n library to Chromium (this CL). 2. Wait till propagates to ...
9 years, 7 months ago (2011-08-10 21:36:19 UTC) #3
Nebojša Ćirić
9 years, 7 months ago (2011-08-11 16:48:23 UTC) #4
I've added Darin and Mads to the project as commiters so they can comment/review
issues (I am not sure if it's necessary).

On 2011/08/10 21:36:19, Nebojša Ćirić wrote:
> 1. Add DEPS to v8-i18n library to Chromium (this CL).
> 2. Wait till propagates to Chromium port of WebKit.
> 3. Update WebKit code to point to the new gyp file, and fix code in
> V8DOMWindowShell (include path and class name).
> 4. Wait for WebKit roll to Chromium to get the new code.
> 5. Remove i18n code from v8 repository.
> 
> On 2011/08/10 21:30:00, Jungshik Shin wrote:
> > LGTM.
> > 
> > Can you describe all 4 steps (including the final removal of i18n stuff from
> the
> > v8 tree)  in the change log for the future reference/record ?

Powered by Google App Engine
This is Rietveld 408576698