Issue 7583032: Merge 95693 - [Sync] Fix encryption/passphrase handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7583032: Merge 95693 - [Sync] Fix encryption/passphrase handling. (Closed)

Created:
9 years, 4 months ago by kerz_chromium

Modified:
9 years, 4 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/branches/835/src/

Visibility:
Public.

Description

Merge 95693 - [Sync] Fix encryption/passphrase handling. We now ensure cached passphrases are always used. In addition, encryption now happens after configuration, allowing us to make use of the pending_encrypted_types to know if we're waiting for encryption (which affects how we prompt for passphrase). This is dependent on sync_setup_flow.cc always calling EncryptDataTypes before configuring the new datatypes and setting pending_encrypted_types_ appropriately, which then gets consumed on SYNC_CONFIGURE_DONE. BUG=91314 TEST=see bug Review URL: http://codereview.chromium.org/7551024 TBR=zea@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95791

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+153 lines, -78 lines)			Patch
M	chrome/browser/sync/engine/syncapi.cc	View	5 chunks	+57 lines, -20 lines	0 comments	Download
M	chrome/browser/sync/engine/syncapi_unittest.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View	3 chunks	+11 lines, -10 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	9 chunks	+53 lines, -34 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_harness.cc	View	1 chunk	+10 lines, -1 line	0 comments	Download
M	chrome/browser/sync/sync_setup_flow.cc	View	2 chunks	+17 lines, -9 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages