build/secondary/third_party/nss/BUILD.gn - Issue 758303002: Revert of clang: Suppress a -Wstring-conversion warnings in nspr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/secondary/third_party/nss/BUILD.gn

Issue 758303002: Revert of clang: Suppress a -Wstring-conversion warnings in nspr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/secondary/third_party/nss/BUILD.gn

diff --git a/build/secondary/third_party/nss/BUILD.gn b/build/secondary/third_party/nss/BUILD.gn

index 16568c031cc1c0e24cf69fb3bc6f8e3e4583ab42..a285ca1720156fbc119c5980b1906ec8593303cd 100644

--- a/build/secondary/third_party/nss/BUILD.gn

+++ b/build/secondary/third_party/nss/BUILD.gn

@@ -332,10 +332,10 @@

"-Wno-incompatible-pointer-types",

# nspr passes "int*" through "unsigned int*".

"-Wno-pointer-sign",

- ]

- # nspr uses assert(!"foo") instead of assert(false && "foo").

- configs -= [ "//build/config/clang:extra_warnings" ]

+ "-Wno-incompatible-pointer-types",

+ "-Wno-pointer-sign",

+ ]

}

« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »