Issue 758273003: Enable logging from mojo_launcher

Issue 758273003: Enable logging from mojo_launcher (Closed)

Created:
6 years ago by Chris Masone

Modified:
6 years ago

Reviewers:
DaveMoore

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Enable logging from mojo_launcher Initialize command line to correctly enable logging in mojo_launcher. BUG=None TEST=run mojo_launcher with --vmodule="*mojo/shell/*=2" and see verbose logs. R=davemoore@chromium.org, davemoore Committed: https://chromium.googlesource.com/external/mojo/+/246b59b772aa977956346123f0b226e318e8d762

Patch Set 1 #

Total comments: 2

Patch Set 2 : init source_set #

Patch Set 3 : rebase #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -7 lines)			Patch
	M	mojo/shell/BUILD.gn	View	1	6 chunks	+16 lines, -3 lines	0 comments	Download
	M	mojo/shell/launcher_main.cc	View		2 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

DaveMoore

https://codereview.chromium.org/758273003/diff/1/mojo/shell/BUILD.gn File mojo/shell/BUILD.gn (right): https://codereview.chromium.org/758273003/diff/1/mojo/shell/BUILD.gn#newcode39 mojo/shell/BUILD.gn:39: "init.h", Files should not be listed more than once. ...

6 years ago (2014-11-26 17:21:53 UTC) #2

Chris Masone

6 years ago (2014-11-26 17:39:57 UTC) #3

Chris Masone

6 years ago (2014-12-01 23:44:04 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
246b59b772aa977956346123f0b226e318e8d762 (presubmit successful).

Expand Messages | Collapse Messages