Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 758133004: Add SK_SUPPORT_LEGACY_PORTER_DUFF macro. (Closed)

Created:
6 years ago by tfarina
Modified:
5 years, 4 months ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org, djsollen, reed1
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add SK_SUPPORT_LEGACY_PORTER_DUFF macro. This trick will be used to remove deprecated SkPorterDuff API. But first we need to add it so Android can be updated later. BUG=skia:3178 R=scroggo@google.com Committed: https://skia.googlesource.com/skia/+/9ed02e40d1069a99c89013b2d442d20e07913206

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M include/effects/SkPorterDuff.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M src/effects/SkPorterDuff.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tfarina
Leon, is it something like this? ptal
6 years ago (2014-12-03 01:35:13 UTC) #1
scroggo
lgtm. You'll need derek or mike's approval since you're changing a header file.
6 years ago (2014-12-03 01:43:10 UTC) #2
reed1
lgtm w/ request for comment https://codereview.chromium.org/758133004/diff/1/include/effects/SkPorterDuff.h File include/effects/SkPorterDuff.h (right): https://codereview.chromium.org/758133004/diff/1/include/effects/SkPorterDuff.h#newcode15 include/effects/SkPorterDuff.h:15: // Temporary guard until ...
6 years ago (2014-12-03 13:41:12 UTC) #4
tfarina
https://codereview.chromium.org/758133004/diff/1/include/effects/SkPorterDuff.h File include/effects/SkPorterDuff.h (right): https://codereview.chromium.org/758133004/diff/1/include/effects/SkPorterDuff.h#newcode15 include/effects/SkPorterDuff.h:15: On 2014/12/03 13:41:11, reed1 wrote: > // Temporary guard ...
6 years ago (2014-12-03 21:02:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758133004/20001
6 years ago (2014-12-03 21:03:25 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-03 21:13:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9ed02e40d1069a99c89013b2d442d20e07913206

Powered by Google App Engine
This is Rietveld 408576698