Issue 758113003: Mocha shouldn't wait for an animation frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 758113003: Mocha shouldn't wait for an animation frame (Closed)

Created:
6 years ago by abarth-chromium

Modified:
6 years ago

Reviewers:
esprehn, rafaelw

CC:
mojo-reviews_chromium.org, ojan, esprehn

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Mocha shouldn't wait for an animation frame When we run the tests headless, we never actually put up frames, which means we never generate animation frames. In this mode, we might want to generate fake animation frames (like DRT does), but for now just use a timeout to make the tests work again. R=rafaelw@chromium.org, esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/046d3e5b123cd5056b6be68519241be5dce96556

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	sky/tests/resources/mocha.sky	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

6 years ago (2014-11-25 19:20:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
046d3e5b123cd5056b6be68519241be5dce96556 (presubmit successful).