Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 758073009: Oilpan: add lazy tracing annotations to recursive objects. (Closed)

Created:
6 years ago by sof
Modified:
6 years ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, tyoshino+watch_chromium.org, pdr+renderingwatchlist_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, Dominik Röttsches, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-rendering, gavinp+loader_chromium.org, jchaffraix+rendering, Nate Chapin, rwlbuis
Project:
blink
Visibility:
Public.

Description

Oilpan: add lazy tracing annotations to recursive objects. To avoid excessively deep call chains if eagerly tracing RenderQuote, ContainerNodes (via its Node member) or MemoryCacheEntry objects, declare these as non-eagerly traceable. R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M Source/core/dom/ContainerNode.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/fetch/MemoryCache.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderQuote.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sof
Please take a look. Eager tracing ran into the depth limit for these three objects ...
6 years ago (2014-12-05 06:20:39 UTC) #2
haraken
Mostly LG, but I'd prefer making a decision that we should go with always-eager and ...
6 years ago (2014-12-05 15:13:47 UTC) #3
sof
On 2014/12/05 15:13:47, haraken wrote: > Mostly LG, but I'd prefer making a decision that ...
6 years ago (2014-12-09 07:40:24 UTC) #4
haraken
On 2014/12/09 07:40:24, sof wrote: > On 2014/12/05 15:13:47, haraken wrote: > > Mostly LG, ...
6 years ago (2014-12-09 08:15:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758073009/1
6 years ago (2014-12-09 12:07:20 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-09 13:17:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186774

Powered by Google App Engine
This is Rietveld 408576698