Source/core/dom/Document.cpp - Issue 758073003: Always propagate direction and writing-mode from <body>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.cpp

Issue 758073003: Always propagate direction and writing-mode from <body>. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added XML and overconstraining tests. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index 3d79b0c6ce7cba5a6fe96df9cd6582043edd39a0..9af267f78ca883833abe1f9b2bab398df6ae65f1 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -498,8 +498,6 @@ Document::Document(const DocumentInit& initializer, DocumentClassFlags documentC

, m_loadEventDelayTimer(this, &Document::loadEventDelayTimerFired)

, m_pluginLoadingTimer(this, &Document::pluginLoadingTimerFired)

, m_referrerPolicy(ReferrerPolicyDefault)

- , m_directionSetOnDocumentElement(false)

- , m_writingModeSetOnDocumentElement(false)

, m_writeRecursionIsTooDeep(false)

, m_writeRecursionDepth(0)

, m_taskRunner(MainThreadTaskRunner::create(this))

@@ -1686,10 +1684,8 @@ void Document::inheritHtmlAndBodyElementStyles(StyleRecalcChange change)

bodyStyle = body->renderStyle();

if (!bodyStyle || body->needsStyleRecalc() || documentElement()->needsStyleRecalc() || change == Force)

bodyStyle = ensureStyleResolver().styleForElement(body, documentElementStyle.get());

- if (!writingModeSetOnDocumentElement())

- rootWritingMode = bodyStyle->writingMode();

- if (!directionSetOnDocumentElement())

- rootDirection = bodyStyle->direction();

+ rootWritingMode = bodyStyle->writingMode();

+ rootDirection = bodyStyle->direction();

}

RefPtr<RenderStyle> overflowStyle;

« no previous file with comments | « Source/core/dom/Document.h ('k') | no next file » | no next file with comments »