src/compiler/instruction-selector-impl.h - Issue 758073002: [turbofan] Use special constant type for RPO block number operands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/instruction-selector-impl.h

Issue 758073002: [turbofan] Use special constant type for RPO block number operands. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/instruction-selector-impl.h

diff --git a/src/compiler/instruction-selector-impl.h b/src/compiler/instruction-selector-impl.h

index 5e4c09055e46a3ffe0aba26da538d5b1ff843765..7813e9b6b9dfaf69a447f47357895b6a97acbc74 100644

--- a/src/compiler/instruction-selector-impl.h

+++ b/src/compiler/instruction-selector-impl.h

@@ -137,8 +137,8 @@ class OperandGenerator {

}

InstructionOperand* Label(BasicBlock* block) {

- // TODO(bmeurer): We misuse ImmediateOperand here.

- return TempImmediate(block->rpo_number());

+ int index = sequence()->AddImmediate(Constant(block->GetRpoNumber()));

+ return ImmediateOperand::Create(index, zone());

}

protected:

« no previous file with comments | « src/compiler/instruction.cc ('k') | src/compiler/mips/code-generator-mips.cc » ('j') | no next file with comments »