Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 758043002: Document that Isolate::GetCurrent() must not be called before initialization (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)
Modified:
6 years ago
Reviewers:
dcarney, ulan
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Document that Isolate::GetCurrent() must not be called before initialization Also, add a check for debug mode. BUG=none R=dcarney@chromium.org LOG=n

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M include/v8.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/isolate.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/isolate.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
6 years ago (2014-11-25 15:02:16 UTC) #1
dcarney
lgtm
6 years ago (2014-11-25 15:04:20 UTC) #2
jochen (gone - plz use gerrit)
+ulan fyi
6 years ago (2014-11-25 15:14:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758043002/1
6 years ago (2014-11-25 15:14:32 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-26 05:15:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698