Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 75803002: [telemetry] Add Monsoon protocol library. (Closed)

Created:
7 years, 1 month ago by dtu
Modified:
7 years ago
Reviewers:
open-source-third-party-reviews, aurimas (slooooooooow), tonyg, ncarter (slow), Daniel Berlin
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org, atreat
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Include PySerial. #

Patch Set 3 : Update and repackage PySerial #

Patch Set 4 : Add guards to avoid exception on Windows. We're not implemented on Windows. #

Patch Set 5 : Move import so that we don't attempt to do it if we're not going to use it. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6610 lines, -10 lines) Patch
A tools/telemetry/telemetry/core/platform/profiler/monsoon.py View 1 2 3 4 1 chunk +275 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/monsoon_profiler.py View 1 2 3 4 2 chunks +2 lines, -12 lines 0 comments Download
A tools/telemetry/third_party/pyserial/LICENSE.txt View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyserial/README.chromium View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/__init__.py View 1 2 1 chunk +79 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/rfc2217.py View 1 2 1 chunk +1323 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/serialcli.py View 1 2 1 chunk +273 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/serialjava.py View 1 2 1 chunk +262 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/serialposix.py View 1 2 1 chunk +703 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/serialutil.py View 1 2 1 chunk +551 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/serialwin32.py View 1 2 1 chunk +461 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/sermsdos.py View 1 2 1 chunk +200 lines, -0 lines 0 comments Download
A + tools/telemetry/third_party/pyserial/serial/tools/__init__.py View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/tools/list_ports.py View 1 2 1 chunk +103 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/tools/list_ports_linux.py View 1 2 1 chunk +143 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/tools/list_ports_osx.py View 1 2 1 chunk +208 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/tools/list_ports_posix.py View 1 2 1 chunk +101 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/tools/list_ports_windows.py View 1 2 1 chunk +240 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/tools/miniterm.py View 1 2 1 chunk +694 lines, -0 lines 0 comments Download
A + tools/telemetry/third_party/pyserial/serial/urlhandler/__init__.py View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/urlhandler/protocol_hwgrep.py View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/urlhandler/protocol_loop.py View 1 2 1 chunk +265 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/urlhandler/protocol_rfc2217.py View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/urlhandler/protocol_socket.py View 1 2 1 chunk +274 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyserial/serial/win32.py View 1 2 1 chunk +320 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
dtu
7 years, 1 month ago (2013-11-19 00:51:45 UTC) #1
tonyg
lgtm According to http://www.chromium.org/developers/adding-3rd-party-libraries , you also need a review from open-source-third-party-reviews@google.com I think the ...
7 years, 1 month ago (2013-11-19 01:19:11 UTC) #2
joth
On 2013/11/19 01:19:11, tonyg wrote: > lgtm > > According to http://www.chromium.org/developers/adding-3rd-party-libraries , you > ...
7 years, 1 month ago (2013-11-19 06:20:56 UTC) #3
dtu
+open-source-third-party-reviews, PTAL
7 years, 1 month ago (2013-11-22 23:34:29 UTC) #4
dtu
On 2013/11/22 23:34:29, dtu wrote: > +open-source-third-party-reviews, PTAL Friendly ping.
7 years ago (2013-12-02 20:34:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/75803002/30001
7 years ago (2013-12-04 20:30:59 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=197160
7 years ago (2013-12-04 21:17:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/75803002/260001
7 years ago (2013-12-06 20:27:35 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=232884
7 years ago (2013-12-07 03:48:13 UTC) #9
Daniel Berlin
lgtm for open-source-third-party-reviews
7 years ago (2013-12-07 04:45:49 UTC) #10
aurimas (slooooooooow)
On 2013/12/07 04:45:49, Daniel Berlin wrote: > lgtm for open-source-third-party-reviews ping?
7 years ago (2013-12-11 15:41:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/75803002/310001
7 years ago (2013-12-16 17:10:06 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=236644
7 years ago (2013-12-16 21:19:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/75803002/310001
7 years ago (2013-12-16 22:09:41 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=236920
7 years ago (2013-12-17 04:33:01 UTC) #15
dtu
On 2013/12/17 04:33:01, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years ago (2013-12-17 22:10:06 UTC) #16
dtu
Committed patchset #5 manually as r241384 (presubmit successful).
7 years ago (2013-12-17 22:15:05 UTC) #17
ncarter (slow)
As sheriff, I reverted this change as r241384
7 years ago (2013-12-17 23:32:24 UTC) #18
dtu
On 2013/12/17 23:32:24, ncarter wrote: > As sheriff, I reverted this change as r241384 checklicenses ...
7 years ago (2013-12-21 00:46:38 UTC) #19
dtu
7 years ago (2013-12-21 00:47:17 UTC) #20
Message was sent while issue was closed. 
Committed patchset #5 manually as r242229 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698