Add SubsampleEntry constructor.

Add SubsampleEntry constructor.

This simplifies some existing code and will make it easier to pass DecryptConfig through mojo.

Also add DecryptConfig::Matches(), which will be useful in tests.

BUG=432998
TEST=Adds new test.

Committed: https://crrev.com/f1132dda40ad38c1bed5232b0b9598e102153b64
Cr-Commit-Position: refs/heads/master@{#305723}

[xhwang, 2014-11-25 17:28:47]

xhwang@chromium.org changed reviewers:
+ ddorwin@chromium.org

[xhwang, 2014-11-25 17:28:47]

xhwang@chromium.org changed required reviewers:
+ ddorwin@chromium.org

[xhwang, 2014-11-25 17:29:37]

PTAL

[ddorwin, 2014-11-25 20:47:48]

lgtm % comments

https://codereview.chromium.org/757953002/diff/1/media/base/decoder_buffer_un...
File media/base/decoder_buffer_unittest.cc (right):

https://codereview.chromium.org/757953002/diff/1/media/base/decoder_buffer_un...
media/base/decoder_buffer_unittest.cc:110:
subsamples.push_back(SubsampleEntry(30, 40));
nit: This example could imply some relation between the two when in reality, 40
would more likely be 20. It might be clearer to have something like:
10, 5
15, 5

https://codereview.chromium.org/757953002/diff/1/media/base/decrypt_config.h
File media/base/decrypt_config.h (right):

https://codereview.chromium.org/757953002/diff/1/media/base/decrypt_config.h#...
media/base/decrypt_config.h:27: SubsampleEntry() : clear_bytes(0),
cypher_bytes(0) {}
Do we need this? It seems like something that should never be used.

[xhwang, 2014-11-25 22:09:43]

rebase only

[xhwang, 2014-11-25 22:13:28]

comments addressed

[xhwang, 2014-11-25 22:13:44]

https://codereview.chromium.org/757953002/diff/1/media/base/decoder_buffer_un...
File media/base/decoder_buffer_unittest.cc (right):

https://codereview.chromium.org/757953002/diff/1/media/base/decoder_buffer_un...
media/base/decoder_buffer_unittest.cc:110:
subsamples.push_back(SubsampleEntry(30, 40));
On 2014/11/25 20:47:48, ddorwin wrote:
> nit: This example could imply some relation between the two when in reality,
40
> would more likely be 20. It might be clearer to have something like:
> 10, 5
> 15, 5

Done.

https://codereview.chromium.org/757953002/diff/1/media/base/decrypt_config.h
File media/base/decrypt_config.h (right):

https://codereview.chromium.org/757953002/diff/1/media/base/decrypt_config.h#...
media/base/decrypt_config.h:27: SubsampleEntry() : clear_bytes(0),
cypher_bytes(0) {}
On 2014/11/25 20:47:48, ddorwin wrote:
> Do we need this? It seems like something that should never be used.

This is needed as the default ctor because we need to  put SubsampleEntry in a
std::vector.

[xhwang, 2014-11-25 22:14:10]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2014-11-25 22:15:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/757953002/40001

[commit-bot: I haz the power, 2014-11-25 23:09:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-25 23:11:12]

Patchset 3 (id:??) landed as
https://crrev.com/f1132dda40ad38c1bed5232b0b9598e102153b64
Cr-Commit-Position: refs/heads/master@{#305723}