Issue 75793003: Make checkdeps.py correctly signal failure when using --json.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 75793003: Make checkdeps.py correctly signal failure when using --json. (Closed)

Created:
7 years, 1 month ago by Paweł Hajdan Jr.

Modified:
7 years, 1 month ago

Reviewers:
Jói

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make checkdeps.py correctly signal failure when using --json. This is a followup to https://codereview.chromium.org/75693002/ TBR=joi BUG=317931 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235865

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tools/checkdeps/results.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Committed patchset #1 manually as r235865 (presubmit successful).

7 years, 1 month ago (2013-11-19 01:04:31 UTC) #1

Jói

7 years, 1 month ago (2013-11-19 08:21:36 UTC) #3

LGTM
 On Nov 19, 2013 1:24 AM, <phajdan.jr@chromium.org> wrote:

> TBR
>
> https://codereview.chromium.org/75793003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages