| Index: test/unittests/base/platform/platform-unittest.cc
|
| diff --git a/test/unittests/base/platform/platform-unittest.cc b/test/unittests/base/platform/platform-unittest.cc
|
| index b972d8ab3e65123d451511c249fcb7c48d637ba4..b17a9b9ef49b6c0737b6480af52d2cee09ac86ed 100644
|
| --- a/test/unittests/base/platform/platform-unittest.cc
|
| +++ b/test/unittests/base/platform/platform-unittest.cc
|
| @@ -13,6 +13,12 @@
|
| #endif
|
| #include "testing/gtest/include/gtest/gtest.h"
|
|
|
| +#if V8_OS_ANDROID
|
| +#define DISABLE_ON_ANDROID(Name) DISABLED_##Name
|
| +#else
|
| +#define DISABLE_ON_ANDROID(Name) Name
|
| +#endif
|
| +
|
| namespace v8 {
|
| namespace base {
|
|
|
| @@ -33,13 +39,13 @@ namespace {
|
| class SelfJoinThread FINAL : public Thread {
|
| public:
|
| SelfJoinThread() : Thread(Options("SelfJoinThread")) {}
|
| - virtual void Run() OVERRIDE { Join(); }
|
| + void Run() FINAL { Join(); }
|
| };
|
|
|
| } // namespace
|
|
|
|
|
| -TEST(Thread, SelfJoin) {
|
| +TEST(Thread, DISABLE_ON_ANDROID(SelfJoin)) {
|
| SelfJoinThread thread;
|
| thread.Start();
|
| thread.Join();
|
| @@ -61,7 +67,7 @@ class ThreadLocalStorageTest : public Thread, public ::testing::Test {
|
| }
|
| }
|
|
|
| - virtual void Run() FINAL OVERRIDE {
|
| + void Run() FINAL {
|
| for (size_t i = 0; i < arraysize(keys_); i++) {
|
| CHECK(!Thread::HasThreadLocal(keys_[i]));
|
| }
|
| @@ -91,16 +97,12 @@ class ThreadLocalStorageTest : public Thread, public ::testing::Test {
|
|
|
| private:
|
| static void* GetValue(size_t x) {
|
| - return reinterpret_cast<void*>(static_cast<uintptr_t>(x + 1));
|
| + return bit_cast<void*>(static_cast<uintptr_t>(x + 1));
|
| }
|
|
|
| -#if defined(ANDROID)
|
| // Older versions of Android have fewer TLS slots (nominally 64, but the
|
| // system uses "about 5 of them" itself).
|
| Thread::LocalStorageKey keys_[32];
|
| -#else
|
| - Thread::LocalStorageKey keys_[256];
|
| -#endif
|
| };
|
|
|
| } // namespace
|
|
|