Issue 757913002: Fix platform unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 757913002: Fix platform unittests. (Closed)

Created:
6 years ago by Benedikt Meurer

Modified:
6 years ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

Fix platform unittests. Follow-up to 87db4ff1f4d76eecb8f19d62f4c04279d56bf229, which added suppressions to unittests.status and a special case for Android to the ThreadLocalStorageTest, both of which are unneccessary and should be handled differently for the GTest based unittests. BUG=v8:3706 LOG=n R=svenpanne@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/9a5ec9c57ce37cb2884ad8fae820dce744bb4eea

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -15 lines)			Patch
	M	test/unittests/base/platform/platform-unittest.cc	View		4 chunks	+10 lines, -8 lines	0 comments	Download
	M	test/unittests/unittests.status	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

Benedikt Meurer

6 years ago (2014-11-25 07:22:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9a5ec9c57ce37cb2884ad8fae820dce744bb4eea (presubmit successful).