Issue 757803003: Make gn check //mojo/* pass on linux and android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 757803003: Make gn check //mojo/* pass on linux and android (Closed)

Created:
6 years ago by jamesr

Modified:
6 years ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@gn_check_services

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make gn check //mojo/* pass on linux and android This suppresses checking for two tricky targets in //mojo/shell with comments explaining why so we can enable checking for the directory unconditionally. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b95dd222cbdefb4ba8da6abb412eee989845556a

Patch Set 1 #

Patch Set 2 : PRESUBMIT.py #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -16 lines)			Patch
M	PRESUBMIT.py	View	1	1 chunk	+1 line, -16 lines	0 comments	Download
M	mojo/android/BUILD.gn	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	mojo/shell/BUILD.gn	View		2 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jamesr

6 years ago (2014-11-25 19:19:57 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
b95dd222cbdefb4ba8da6abb412eee989845556a (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages