.close() build.ninja in ninja generator

.close() build.ninja in ninja generator

Appears to fix EOF corruption in build.ninja that appeared when
upgrading from python 2.6 to python 2.7.6 on XP hosts.

R=thakis@chromium.org, maruel@chomium.org

Committed: https://code.google.com/p/gyp/source/detail?r=1792

[scottmg, 2013-11-19 00:13:59]

OTOH, this simple program works fine on the XP VM with 2.7.6. It seems
reasonable to properly close the file anyway though, so I think this worth
trying.

---
import os
import random
import sys

def main():
  if len(sys.argv) == 1:
    for i in range(1000):
      os.system(sys.executable + ' ' + __file__ + ' %d' % i)
  else:
    f = open('test_%s.txt' % sys.argv[1], 'w')
    random.seed(1234)
    for i in range(1000):
      j = random.randint(32, 122)
      f.write(chr(j) * j)

if __name__ == '__main__':
  main()
---

[Nico, 2013-11-19 00:20:18]

lgtm

https://codereview.chromium.org/75773002/diff/1/pylib/gyp/generator/ninja.py
File pylib/gyp/generator/ninja.py (right):

https://codereview.chromium.org/75773002/diff/1/pylib/gyp/generator/ninja.py#...
pylib/gyp/generator/ninja.py:1659: build_ninja =
OpenOutput(os.path.join(toplevel_build, 'build.ninja'))
master_ninja_file?

[scottmg, 2013-11-19 00:21:45]

On 2013/11/19 00:20:18, Nico (in Tokyo until Nov 25) wrote:
> lgtm
> 
> https://codereview.chromium.org/75773002/diff/1/pylib/gyp/generator/ninja.py
> File pylib/gyp/generator/ninja.py (right):
> 
>
https://codereview.chromium.org/75773002/diff/1/pylib/gyp/generator/ninja.py#...
> pylib/gyp/generator/ninja.py:1659: build_ninja =
> OpenOutput(os.path.join(toplevel_build, 'build.ninja'))
> master_ninja_file?

Done.

[scottmg, 2013-11-19 00:25:23]

Committed patchset #2 manually as r1792.