gin/modules/module_registry.cc - Issue 757703002: Creates a JavaScript Applicaiton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/modules/module_registry.cc

Issue 757703002: Creates a JavaScript Applicaiton (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Changes per review feedback Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/modules/module_registry.cc

diff --git a/gin/modules/module_registry.cc b/gin/modules/module_registry.cc

index a92a5461af1a20910415b32111118ce73e9a136c..8341337829d18dc3b08d72a052cc5b345b233b8f 100644

--- a/gin/modules/module_registry.cc

+++ b/gin/modules/module_registry.cc

@@ -168,6 +168,12 @@ void ModuleRegistry::LoadModule(Isolate* isolate,

return;

}

waiting_callbacks_.insert(std::make_pair(id, callback));

+ for (size_t i = 0; i < pending_modules_.size(); ++i) {

+ if (pending_modules_[i]->id == id)

+ return;

+ }

unsatisfied_dependencies_.insert(id);

}